Rename our "host" vocabulary to "agent", the term DWService uses - #5
Merged
Conversation
dwshell called the machine you connect to a "host". DWService does not:
its own English strings shipped with the agent say "Agent name",
"Creating a new agent", "The agent {0} already exists" — 39 occurrences
of "agent" against one of "host", and that one is `proxyHost`, a network
proxy. The protocol modules are `agent`, `share` and `group`.
Speaking the service's language matters more now that agent management
is coming: a command group named after the thing it manages reads wrong
if the rest of the CLI calls that thing something else.
Not a breaking change: "host" was never a flag or a config key, only
variable names, help text and prose.
Three things keep the word, because there it means a network host and
renaming would be wrong or would falsify a record:
- internal/client — the local machine's hostname, used to label a
registered trusted device ("dwshell on <hostname>");
- internal/session/socket.go — the relay host (u.Host);
- docs/PROTOCOL.md — "Hosts and terminology" is about the service's
own domains, and two further hits are captured terminal output
(user@host:~#) and a file literally named "hosts";
- docs/DESIGN.md keeps "conhost", the Windows console host, and the
README keeps "repositories are hosted at".
parseUserHost becomes parseUserAndAgent rather than parseUserAgent,
which would read as the HTTP header.
Pure rename: 130 insertions against 130 deletions, no logic touched.
Verified beyond the suite by exercising the real paths against live
agents — list, -c with its exit code, and ls on a remote directory.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01MvidAFW9a2r4hTgHPW9ywG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminology only — no behaviour change, no breaking change.
Why
dwshell called the machine you connect to a "host". DWService does not. Its own English strings, shipped with the agent (
ui/messages/default.py), say:39 occurrences of "agent" against exactly one of "host" — and that one is
proxyHost, a network proxy setting. The protocol modules areagent,share,group.This matters now because agent management is coming: a command group named after the thing it manages reads wrong if the rest of the CLI calls that thing something else.
Not breaking: "host" was never a flag or a config key — only variable names, help text and prose.
What keeps the word
Where "host" means a network host, renaming would be wrong or would falsify a record:
internal/client— the local hostname labelling a registered trusted device (dwshell on <hostname>)internal/session/socket.go— the relay host (u.Host)docs/PROTOCOL.md— "Hosts and terminology" is about the service's domains; two further hits are captured terminal output (user@host:~#) and a file literally namedhostsconhost(the Windows console host) in DESIGN.md, and "repositories are hosted at" in the READMEparseUserHostbecomesparseUserAndAgent, notparseUserAgent, which would read as the HTTP header.Verification
gofmt,go vet,go test -race ./...greenlist,-cwith its exit code propagated, andlson a remote directory🤖 Generated with Claude Code
https://claude.ai/code/session_01MvidAFW9a2r4hTgHPW9ywG